Skip to content

Correct event pattern content to align with guides #30994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2022
Merged

Correct event pattern content to align with guides #30994

merged 4 commits into from
Sep 6, 2022
+106 −187

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Sep 2, 2022 •
edited
Loading

Summary

  • Edit pass
  • Format
  • Address customer feedback on event patterns

Fixes #13906

Preview

https://review.docs.microsoft.com/en-us/dotnet/csharp/event-pattern?branch=pr-en-us-30994

@dotnet-bot dotnet-bot added this to the September 2022 milestone Sep 2, 2022
@IEvangelist IEvangelist added the okr-freshness OKR: Freshness of content label Sep 2, 2022
BillWagner
BillWagner approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IEvangelist

This LGTM. Let's :shipit:

@IEvangelist IEvangelist merged commit 972cde3 into dotnet:main Sep 6, 2022
@IEvangelist IEvangelist changed the title Fix 13096 Correct event pattern content to align with guides Sep 6, 2022
@IEvangelist IEvangelist mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@gewarren gewarren Awaiting requested review from gewarren gewarren is a code owner

Assignees
No one assigned
Labels
dotnet-csharp/svc okr-freshness OKR: Freshness of content
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Article doesn't follow important event conventions
3 participants
@IEvangelist @BillWagner @dotnet-bot